REST bridge: remove WAMP ticket auth forwarding#1500
Merged
oberstet merged 3 commits intocrossbario:masterfrom Feb 22, 2019
Merged
REST bridge: remove WAMP ticket auth forwarding#1500oberstet merged 3 commits intocrossbario:masterfrom
oberstet merged 3 commits intocrossbario:masterfrom
Conversation
This reverts commit 703507f.
Contributor
|
That's a scary pull request. Is this really removing ticket authentication from crossbar? |
Contributor
|
Ah, no;) What's removed is only code that forwarded HTTP to WAMP-Ticket Auth - that code is a security problem (and the design approach unfortunately "broken by design"). we are working on a replacement for the ability to authenticate the incoming HTTP to Web services defined in crossbar .. |
oberstet
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1500 +/- ##
=========================================
- Coverage 37.42% 37% -0.42%
=========================================
Files 76 77 +1
Lines 11602 11711 +109
Branches 2120 2130 +10
=========================================
- Hits 4342 4334 -8
- Misses 6839 6947 +108
- Partials 421 430 +9
Continue to review full report at Codecov.
|
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Nov 25, 2021
Changelog:
fix: autobahn installation in docker
(crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
(crossbario/crossbar#1500,
crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
(crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
(crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
(crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
(crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI
Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Nov 25, 2021
Changelog:
fix: autobahn installation in docker
(crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
(crossbario/crossbar#1500,
crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
(crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
(crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
(crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
(crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI
Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Nov 26, 2021
Changelog:
fix: autobahn installation in docker
(crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
(crossbario/crossbar#1500,
crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
(crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
(crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
(crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
(crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI
Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Nov 27, 2021
Changelog:
fix: autobahn installation in docker
(crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
(crossbario/crossbar#1500,
crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
(crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
(crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
(crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
(crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI
Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Nov 29, 2021
Changelog:
fix: autobahn installation in docker
(crossbario/crossbar#1503)
new: refactor SigningKey class for reusability
(crossbario/crossbar#1500,
crossbario/crossbar#1501)
new: expand XBR node pairing helpers
fix: build with nvx by default and don't publish universal wheel.
(crossbario/crossbar#1493)
fix: update wamp flatbuffer schema for r2r links
fix: don't clobber factory
(crossbario/crossbar#1480)
fix: explicitly require setuptools
new: expand wamp auth scram and xbr argon2/hkdf
(crossbario/crossbar#1479)
fix: WebSocket compression, window size (zlib wbits) == 8 is illegal nowerdays
(crossbario/crossbar#1477)
fix: XBR IDL code generator - all 4 WAMP actions working now
new: add automated build of xbrnetwork CLI (single-file EXE) in CI
Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.